Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1561#discussion_r15328333
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -315,13 +309,14 @@ class DAGScheduler(
*/
private def updateJobIdStageIdMaps(jobId: Int, stage: Stage) {
def updateJobIdStageIdMapsList(stages: List[Stage]) {
- if (!stages.isEmpty) {
+ if (stages.nonEmpty) {
val s = stages.head
- stageIdToJobIds.getOrElseUpdate(s.id, new HashSet[Int]()) += jobId
+ s.jobIds += jobId
jobIdToStageIds.getOrElseUpdate(jobId, new HashSet[Int]()) += s.id
- val parents = getParentStages(s.rdd, jobId)
- val parentsWithoutThisJobId = parents.filter(p =>
- !stageIdToJobIds.get(p.id).exists(_.contains(jobId)))
+ val parents: List[Stage] = getParentStages(s.rdd, jobId)
--- End diff --
It is not obvious to me what getParentStages return just staring at the
code. Sometimes when we refer to stages we use a set of integers, sometimes
just Stage objects.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
