Github user markhamstra commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1561#discussion_r15328468
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -341,8 +336,9 @@ class DAGScheduler(
         if (registeredStages.isEmpty || registeredStages.get.isEmpty) {
           logError("No stages registered for job " + job.jobId)
         } else {
    -      stageIdToJobIds.filterKeys(stageId => 
registeredStages.get.contains(stageId)).foreach {
    -        case (stageId, jobSet) =>
    +      stageIdToStage.filter(s => 
registeredStages.get.contains(s._1)).foreach {
    --- End diff --
    
    Why filter instead of filterKeys?  Looks to me like that only serves to 
make the predicate harder to read.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to