Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/11466#discussion_r55117873
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -78,6 +78,27 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
}
}
+ private def toSQL(node: LogicalPlan, topNode: Boolean): String = {
--- End diff --
Actually, I am also afraid that the test case here for `Join` is not valid.
I guess `Join` is the top layer node only when users are using
DataFrame/DataSet APIs. If users are using SQL, `Join` will not be the top
layer node, right?
If we want to convert the analyzed logical plan generated from DataFrame
API to SQL, this is not the only issue. I also hit a couple of issues before.
@liancheng , do you think we should support them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
