Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11466#discussion_r55118363
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
    @@ -78,6 +78,27 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext: 
SQLContext) extends Loggi
         }
       }
     
    +  private def toSQL(node: LogicalPlan, topNode: Boolean): String = {
    --- End diff --
    
    After rethinking this issue, I believe SQL generation of partial 
**optimized** plans is very important for federation to RDBMS. However, SQL 
generation of optimized plans is much more complex. So far, it is not the 
purpose. I am wondering if SQL generation of partial **analyzed** plans is 
needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to