Github user oliverpierson commented on the pull request:

    https://github.com/apache/spark/pull/11553#issuecomment-193584221
  
    Putting this up for review now.  Tests are passing on my machine.  Using 
`approxQuantile` in DataFrame stats reduces amount of code required by a good 
bit.
    
    As for the default `relativeError` value, which is passed onto 
`approxQuantile`... perhaps @jkbradley has a suggestion?  I basically chose 
0.01 on whim, since I couldn't really make a compelling argument for any 
particular value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to