Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/11553#discussion_r55333861
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala
---
@@ -99,33 +73,3 @@ class QuantileDiscretizerSuite
testDefaultReadWrite(t)
}
}
-
-private object QuantileDiscretizerSuite extends SparkFunSuite {
-
- def checkDiscretizedData(
- sc: SparkContext,
- data: Array[Double],
- numBucket: Int,
- expectedResult: Array[Double],
- expectedAttrs: Array[String]): Unit = {
- val sqlCtx = SQLContext.getOrCreate(sc)
- import sqlCtx.implicits._
-
- val df = sc.parallelize(data.map(Tuple1.apply)).toDF("input")
- val discretizer = new
QuantileDiscretizer().setInputCol("input").setOutputCol("result")
- .setNumBuckets(numBucket).setSeed(1)
- val model = discretizer.fit(df)
- assert(model.hasParent)
--- End diff --
The `assert(model.hasParent)` test was added as part of #11214, see
https://github.com/apache/spark/pull/11214/files#diff-22d5d4af1af0a7c9d606c5d82b5743f4R97
for reference. Please could we include this test in the new tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
