Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11534#discussion_r55619205
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -114,89 +106,70 @@ private[spark] class MemoryStore(blockManager:
BlockManager, memoryManager: Memo
if (putSuccess) {
assert(bytes.limit == size)
}
- }
-
- override def putIterator(
- blockId: BlockId,
- values: Iterator[Any],
- level: StorageLevel): Either[Iterator[Any], Long] = {
- require(!contains(blockId), s"Block $blockId is already present in the
MemoryStore")
- putIterator(blockId, values, level, allowPersistToDisk = true)
+ putSuccess
}
/**
* Attempt to put the given block in memory store.
*
- * There may not be enough space to fully unroll the iterator in memory,
in which case we
- * optionally drop the values to disk if
- * (1) the block's storage level specifies useDisk, and
- * (2) `allowPersistToDisk` is true.
--- End diff --
great! I hated this flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
