Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11534#issuecomment-194600143
@JoshRosen This looks great. The only concern I have is the duplicate code
in `doPutIterator` and `doPutBytes`. In the future if we find a bug in one of
them and forget to fix it in the other place things will get really hard to
maintain. I do agree on the general idea of separating the two instead of
having one giant monolithic `doPut` method, but I really think we need to fix
the duplicate code here and I would prefer to do it in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
