Github user atongen commented on the pull request:

    https://github.com/apache/spark/pull/10949#issuecomment-197568469
  
    @tnachen: I reviewed the tests introduced by 
https://github.com/apache/spark/pull/5563, and from what I can tell they are 
mainly testing only MesosSchedulerUtils#matchesAttributeRequirements in regard 
to attribute constraints; which is the only significant thing introduced by 
this PR.
    
    Without further refactoring, testing at the next level up 
(MesosClusterScheduler#scheduleTasks) would require a functioning 
MesosClusterPersistenceEngine (not the black hole), and quite a bit of 
additional scaffolding.
    
    Let me know if this is still a requirement. I would like to confirm before 
putting in the effort.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to