Github user tnachen commented on the pull request:
https://github.com/apache/spark/pull/10949#issuecomment-197585699
I think we should add tests and I don't think it requires that much
refactoring, if you look at MesosClusterSchedulerSuite you can see the test
"can handle multiple roles" already tries a submission and verifies it uses the
Offer passed in, we can also test by doing a similiar setup where we have a
Offer with attributes and without and verify it's performing the correct logic.
Tests is very important and we're looking to really increase our coverage as
it's getting harder and harder to catch things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
