Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11636#discussion_r56482715
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
 ---
    @@ -158,9 +158,13 @@ class CodegenContext {
       /** The variable name of the input row in generated code. */
       final var INPUT_ROW = "i"
     
    +  /** The variable name of the input col in generated code. */
    +  var INPUT_COLORDINAL = "idx"
    +
       /**
         * The map from a variable name to it's next ID.
         */
    +  private val freshNameJavaTypes = new mutable.HashMap[String, String]
    --- End diff --
    
    It is also used in ```CodeGenerator.getValue()```. This is called from 
other classes rather than ```DataSourceScan```. Thus, can we keep this in 
```CodeGenerator.scala```?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to