Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11636#discussion_r56724708
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -217,9 +222,14 @@ private[sql] case class DataSourceScan(
// TODO: The abstractions between this class and SqlNewHadoopRDD makes
it difficult to know
// here which path to use. Fix this.
- ctx.INPUT_ROW = row
ctx.currentVars = null
- val columns1 = exprs.map(_.gen(ctx))
+ val colVars = output.zipWithIndex.map(x => ctx.freshName("col" + x._2))
+ val colDeclarations = colVars.zipWithIndex.map(x => {
+ (columnVectorClz + " " + x._1 + " = " + batch + ".column(" + x._2 +
");\n").trim} )
--- End diff --
@davies , this comment makes sense.
Since the class
[```ColumnarBatch```](https://github.com/apache/spark/blob/f96997ba244a14c26e85a2475415a762d0c0d0a8/sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/ColumnarBatch.java#L47)
is declared as final, I expect a method call ```batch.column()``` is inlined
as ```batch.columns[]``` by a Java JIT compiler.
Or, is it better to explicitly access ```batch.columns[]``` by making
```ColumnarBatch.columns[]``` public?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
