Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11578#issuecomment-199140544
@mengxr I am not sure why you said this would generate more values than the
number of elements.
Besides, for the performance improvement is not significant, it should mean
that comparing this and using generated Java codes (basically as same as this
change, but move some logic to generated codes) for sample() in Sampler. Not
about with this change or not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
