Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/11578#issuecomment-199162363
@rxin yeah, I've benchmarked the performance difference by implementing
generated codes for both cases, the results are shown above. It is not
significant.
For sample without replacement, I put the condition branch in the generated
codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
