Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/11852#discussion_r56937629
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -52,7 +52,8 @@ class LBFGS(private var gradient: Gradient, private var
updater: Updater)
* Restriction: numCorrections > 0
*/
def setNumCorrections(corrections: Int): this.type = {
- assert(corrections > 0)
+ require(corrections > 0, s"Number of corrections must be greater than
0," +
+ s" but got ${corrections}")
--- End diff --
Would the following style fit? If yes, this is slightly easier to read.
~~~scala
require(corrections > 0,
s"Number of corrections must be greater than 0 but got ${corrections}")
~~~
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
