Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11882#discussion_r56947602
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -244,6 +247,17 @@ private void decodeDictionaryIds(int rowId, int num,
ColumnVector column,
switch (descriptor.getType()) {
case INT32:
case INT64:
+ case INT96:
+ if (column.dataType() == DataTypes.TimestampType) {
+ for (int i = rowId; i < rowId + num; ++i) {
+ Binary v = dictionary.decodeToBinary(dictionaryIds.getInt(i));
--- End diff --
hm -- maybe we can do something a lot cheaper? At the very least maybe we
can remove the creation of the this Binary object, since we are turning it
immediately into a Long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
