Github user nongli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11882#discussion_r57026910
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
 ---
    @@ -308,7 +322,7 @@ private void readIntBatch(int rowId, int num, 
ColumnVector column) throws IOExce
     
       private void readLongBatch(int rowId, int num, ColumnVector column) 
throws IOException {
         // This is where we implement support for the valid type conversions.
    -    if (column.dataType() == DataTypes.LongType ||
    +    if (column.dataType() == DataTypes.LongType || column.dataType() == 
DataTypes.TimestampType ||
             DecimalType.is64BitDecimalType(column.dataType())) {
           defColumn.readLongs(
    --- End diff --
    
    Do we have tests where this type is *not* dictionary encoded?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to