Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1195#discussion_r15494467
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceiverSupervisorImpl.scala
---
@@ -108,11 +106,23 @@ private[streaming] class ReceiverSupervisorImpl(
optionalMetadata: Option[Any],
optionalBlockId: Option[StreamBlockId]
) {
+ pushArrayBuffer(arrayBuffer, optionalMetadata, optionalBlockId, None)
+ }
+
+
+ /** Store an ArrayBuffer of received data as a data block into Spark's
memory. */
+ override def pushArrayBuffer(
+ arrayBuffer: ArrayBuffer[_],
+ optionalMetadata: Option[Any],
+ optionalBlockId: Option[StreamBlockId],
+ optionalCallback: Option[() => Unit]
+ ) {
val blockId = optionalBlockId.getOrElse(nextBlockId)
val time = System.currentTimeMillis
blockManager.putArray(blockId, arrayBuffer.toArray[Any], storageLevel,
tellMaster = true)
logDebug("Pushed block " + blockId + " in " +
(System.currentTimeMillis - time) + " ms")
reportPushedBlock(blockId, arrayBuffer.size, optionalMetadata)
+ callback(optionalCallback)
--- End diff --
Calling callback on the same thread that is doing the block pushing may not
be the best idea. If the callback does something time consuming, then it will
halt all the block pushing. We can go with this for now, but lets make sure
that the Spark Sink's callback is not time consuming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
