Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1195#discussion_r15494993
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/receiver/Receiver.scala ---
    @@ -133,12 +143,34 @@ abstract class Receiver[T](val storageLevel: 
StorageLevel) extends Serializable
         executor.pushArrayBuffer(dataBuffer, Some(metadata), None)
       }
     
    +  /**
    +   * Store an ArrayBuffer of received data as a data block into Spark's 
memory.
    +   * The metadata will be associated with this block of data
    +   * for being used in the corresponding InputDStream. The callback is
    +   * called when the data is safely stored. This callback can be used to 
commit transactions
    +   * with systems from which data is being sent etc.
    +   */
    +  @Experimental
    +  def storeReliably(dataBuffer: ArrayBuffer[T], metadata: Any, callback: 
Option[() => Unit]) {
    --- End diff --
    
    This is small style preference of mine (so no strong arguments), but could 
you put all the "storeReliably" function together rather than inter-mixed with 
store function?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to