Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11874#discussion_r57254527
  
    --- Diff: 
core/src/main/scala/org/apache/spark/memory/StaticMemoryManager.scala ---
    @@ -17,6 +17,8 @@
     
     package org.apache.spark.memory
     
    +import scala.util.control.NonFatal
    +
    --- End diff --
    
    by the way I'm not sure whether it's worth it to change anything here. This 
is for legacy mode and will be removed in the future anyway, and for those 
people who *are* using it they're doing so because the new workload doesn't 
work for them, so it's best to just keep things the same here as much as 
possible. I don't feel super strongly about reverting the changes here but I 
don't think it's totally necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to