Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11874#discussion_r57259282
--- Diff:
core/src/main/scala/org/apache/spark/storage/memory/MemoryStore.scala ---
@@ -338,24 +345,51 @@ private[spark] class MemoryStore(
* RDDs that don't fit into memory that we want to avoid).
*
* @param blockId the ID of the block we are freeing space for, if any
- * @param space the size of this block
- * @return the amount of memory (in bytes) freed by eviction
+ * @param requestedSpace the amount of memory which should be freed via
block eviction
+ * @return the total size (in bytes) of the blocks evicted from the
MemoryStore. This memory is
+ * not released with the memory manager, so it's the caller's
responsibility to perform
+ * the appropriate bookkeeping calls.
--- End diff --
Is it because we want to transfer memory atomically to accommodate the new
storage memory requests? Then we should say so in the comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
