Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/11553#issuecomment-202819300
My only issue with leaving the getters unchanged is, how do you actually
know what the computed relative error is (as the getters throw
`NoSuchElementException` since the default is unset)? e.g. in a pipeline or
cross-validation scenario.
@mengxr @oliverpierson thinking about it a bit more, perhaps we're trying
to be too clever here? In practice from what I can see in the approx quantile
paper, there is not too much memory overhead for rel error around `0.01` and
this seems to make sense to me as a default. I'd have gone with using a default
that is the same as `approxQuantile` if one existed. Perhaps we can set a
default there too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
