Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/11553#issuecomment-204018629
@oliverpierson @MLnick There are multiple ways to retrieve a param value.
For example, users can call `explainParams` to see all param docs and values.
It would confuse users if the output there is different from
`getRelativeError`. My recommendation is put a default value here and do not
make getter special. Even with `0.001` I don't think the memory requirement is
crazily high.
Then the next question is whether we should adjust the relative error based
on the number of buckets. Even with more than `1/relErr` buckets, the output is
still right in terms of relative error. There might be cases I want to have
more buckets but okay with large relative error. We can just log a warning
message in this case instead of modifying the input relative error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
