Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12036#issuecomment-203215691
@andrewor14 I go through #12051 again. Your main change is in
`HiveFunctionRegistry`. I compare our changes in this place and they are nearly
doing the same thing, excepts for few differences.
However, in order to make the temporary function work in Spark, instead of
passing through Hive, there are many places needed to take care as I did in
this PR.
I think to duplicate our works is not making sense. As your PR just begins
with few changes. I think my changes in this PR are functional and ready for
review. I will suggest we focus on this change.
What do you think?
cc @yhuai @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
