Github user zhonghaihua commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10794#discussion_r57838823
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -81,8 +82,20 @@ private[yarn] class YarnAllocator(
         new ConcurrentHashMap[ContainerId, java.lang.Boolean])
     
       @volatile private var numExecutorsRunning = 0
    -  // Used to generate a unique ID per executor
    -  private var executorIdCounter = 0
    +
    +  /**
    +   * Used to generate a unique ID per executor
    +   *
    +   * Init `executorIdCounter`. when AM restart, `executorIdCounter` will 
reset to 0. Then
    +   * the id of new executor will start from 1, this will conflict with the 
executor has
    --- End diff --
    
    I think we can clarify this in `SPARK-12864` issue. @andrewor14 What's your 
opinion ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to