Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/10794#discussion_r57886080
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedClusterMessage.scala
---
@@ -30,6 +30,8 @@ private[spark] object CoarseGrainedClusterMessages {
case object RetrieveSparkProps extends CoarseGrainedClusterMessage
+ case object RetrieveMaxExecutorId extends CoarseGrainedClusterMessage
--- End diff --
I understand what the variable is, but readers looking at just this message
without other context wouldn't necessarily know. When I look at the name I
think its giving me some limit for max executor id. For instance we have many
configs that set max of things ( for instance spark.reducer.maxSizeInFlight,
spark.shuffle.io.maxRetries, etc.) That is why I would like the name
clarified.
If we change the calling context, then its not just the max executor id for
the last AM, its the last executor id that was allocated. So perhaps rename to
be RetrieveLastAllocatedExecutorId
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
