Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12036#discussion_r57960777
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionState.scala ---
    @@ -29,7 +29,7 @@ import org.apache.spark.sql.internal.{SessionState, 
SQLConf}
     /**
      * A class that holds all session-specific state in a given 
[[HiveContext]].
      */
    -private[hive] class HiveSessionState(ctx: HiveContext) extends 
SessionState(ctx) {
    +private[hive] class HiveSessionState(val ctx: HiveContext) extends 
SessionState(ctx) {
    --- End diff --
    
    please don't do this; if someone needs the context then we should 
explicitly pass in the context itself instead of getting it through the session 
state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to