Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12036#issuecomment-203638477
I just did a close review and there were a few design choices that I would
like to discuss further. The biggest thing is I'm not sure if it's the
responsibility of `HiveFunctionRegistry.lookupFunction` to load the hive jars
as well. Right now we need to pass in `HiveContext` and `SessionCatalog` into
`HiveFunctionRegistry`, which seems like a messy design because it couples
these few classes too closely. I think a better place to load the hive jars
will be in `HiveSessionCatalog` itself, which already takes in a `HiveContext`.
@yhuai What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
