Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12061#discussion_r57973333
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -70,4 +70,13 @@ class WholeStageCodegenSuite extends SparkPlanTest with
SharedSQLContext {
p.asInstanceOf[WholeStageCodegen].child.isInstanceOf[Sort]).isDefined)
assert(df.collect() === Array(Row(1), Row(2), Row(3)))
}
+
+ test("typed filter should be included in WholeStageCodegen") {
+ val ds = sqlContext.range(10).filter(_ % 2 == 0)
--- End diff --
this is a risky thing because as soon as we introduce
https://issues.apache.org/jira/browse/SPARK-14083 this test will be useless.
maybe we should introduce a config option now and then explicitly turn off
that future optimization
cc @JoshRosen - any good names for the config option?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
