Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12061#discussion_r57974476
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -526,6 +539,18 @@ class Analyzer(
}
}
+ private def containsUnresolvedNewInstance(expr: Expression): Boolean =
expr.find {
+ case n: NewInstance if needOuterScope(n) => true
+ case _ => false
+ }.isDefined
+
+ private def needOuterScope(n: NewInstance): Boolean = {
+ // If this is an inner class of another class, register the outer
object in `OuterScopes`.
+ // Note that static inner classes (e.g., inner classes within Scala
objects) don't need
+ // outer pointer registration.
+ n.outerPointer.isEmpty && n.cls.isMemberClass &&
!Modifier.isStatic(n.cls.getModifiers)
--- End diff --
Could this go into `NewInstance`? it seems like `resolved` should be
`false` until this is satisfied.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
