Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/12036#discussion_r58006735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -67,9 +77,14 @@ class SimpleFunctionRegistry extends FunctionRegistry {
}
override def lookupFunction(name: String, children: Seq[Expression]):
Expression = {
+ val builder = functionBuilders.get(name)
+ if (builder.isEmpty) {
+ throw new AnalysisException(s"undefined function $name")
+ }
val func = synchronized {
- functionBuilders.get(name).map(_._2).getOrElse {
- throw new AnalysisException(s"undefined function $name")
+ Try(builder.map(_._2)) match {
--- End diff --
Hive's exception will be thrown. I faced the exception thrown in working on
the changes. One jenkins test checks the error message. We will miss the actual
exception and message and only get AnalysisException with `undefined function`
here. I think it is proper to show real error message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
