Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58081429
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/windowExpressions.scala
---
@@ -451,7 +451,7 @@ abstract class RowNumberLike extends
AggregateWindowFunction {
* A [[SizeBasedWindowFunction]] needs the size of the current window for
its calculation.
*/
trait SizeBasedWindowFunction extends AggregateWindowFunction {
- protected def n: AttributeReference = SizeBasedWindowFunction.n
+ val n: AttributeReference = SizeBasedWindowFunction.n
--- End diff --
How about we add this kind of comments to the code in future? For this one,
we can add it when we check it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
