Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12040#discussion_r58090749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Window.scala ---
@@ -937,6 +945,12 @@ private[execution] object AggregateProcessor {
imperatives.toArray,
trackPartitionSize)
}
+
+ // SPARK-14244: When binding
+ def windowPartitionSizeAttribute(expressions: Array[Expression]):
AttributeReference = {
+ val aggs = expressions.flatMap(_.collectFirst { case f:
SizeBasedWindowFunction => f })
+ aggs.headOption.map(_.n).getOrElse(SizeBasedWindowFunction.n)
--- End diff --
If we do not have any `SizeBasedWindowFunction`, should this method be
called? When will we need to use `SizeBasedWindowFunction.n` created at the
executor side? I guess I am confused why we need
https://github.com/apache/spark/pull/12040/files#diff-5dade93a3cce85de2ceeab02bd9d4ff6R931.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
