GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/12109
[MINOR][SQL] Fix comments style and corrects several styles in CSV data
source
## What changes were proposed in this pull request?
While trying to create a PR (which was not an issue at the end), I just
corrected some style nits.
So, I removed the changes except for some coding style corrections.
- According to the
[scala-style-guide#documentation-style](https://github.com/databricks/scala-style-guide#documentation-style),
Scala style comments are discouraged.
>```scala
>/** This is a correct one-liner, short description. */
>
>/**
> * This is correct multi-line JavaDoc comment. And
> * this is my second line, and if I keep typing, this would be
> * my third line.
> */
>
>/** In Spark, we don't use the ScalaDoc style so this
> * is not correct.
> */
>```
- According to
[scala-style-guide#blank-lines-vertical-whitespace](https://github.com/databricks/scala-style-guide#blank-lines-vertical-whitespace),
single newline appears when
>Between consecutive members (or initializers) of a class: fields,
constructors, methods, nested classes, static initializers, instance
initializers.
So, this PR also removes the line.
- Remove uesless parentheses in tests
- Use `mapPartitions` instead of `mapPartitionsWithIndex()`.
## How was this patch tested?
Unit tests were used and `dev/run_tests` for style tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark SPARK-14271
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12109
----
commit c8f1745689d82b6b0cc714ac326ce8cf65888f61
Author: hyukjinkwon <[email protected]>
Date: 2016-04-01T08:58:29Z
Support for reading with rowSeparator option
commit b8f09347cfe4aa7f371d4964a0452ed711d82bfb
Author: hyukjinkwon <[email protected]>
Date: 2016-04-01T09:46:26Z
Reverts changes
commit 784d8f7ba3120c9873517d3137284e44ebe5ccca
Author: hyukjinkwon <[email protected]>
Date: 2016-04-01T09:48:45Z
Java style comments
commit 878ae8911480ca48e0dd5ed7d10fff2670d97514
Author: hyukjinkwon <[email protected]>
Date: 2016-04-01T09:50:25Z
Revert other changes as well and correct style
commit f56e748ed81711a98d70427b791a790f26da471d
Author: hyukjinkwon <[email protected]>
Date: 2016-04-01T09:51:34Z
Revert toString() to toString
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
