Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12109#discussion_r58233581
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -42,12 +42,12 @@ object CSVRelation extends Logging {
firstLine: String,
params: CSVOptions): RDD[Array[String]] = {
// If header is set, make sure firstLine is materialized before
sending to executors.
- file.mapPartitionsWithIndex({
- case (split, iter) => new BulkCsvReader(
+ file.mapPartitions { iter =>
--- End diff --
This is legitimately a little optimization, but the rest feels too minor to
bother with. Really there are more instances of slightly mis-spaced scaladoc or
lines of code, though to fix them all would be time-consuming. Fixing them when
nearby code changes is sensible. Fixing a few at random doesn't feel like a
great goal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
