Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11976#discussion_r58272833
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Trigger.scala ---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql
+
+import java.util.concurrent.TimeUnit
+
+import scala.concurrent.duration.Duration
+
+import org.apache.commons.lang3.StringUtils
+
+import org.apache.spark.unsafe.types.CalendarInterval
+
+/**
+ * A interface that indicates how to run a batch.
+ */
+sealed trait Trigger {}
+
+/**
+ * A trigger that runs a query periodically based on the processing time.
If `intervalMs` is 0,
+ * the query will run as fast as possible.
+ *
+ * Scala Example:
+ * {{{
+ * def.writer.trigger(ProcessingTime(10.seconds))
+ * def.writer.trigger(ProcessingTime("10 seconds"))
+ * }}}
+ *
+ * Java Example:
+ *
+ * {{{
+ * def.writer.trigger(ProcessingTime.create(10, TimeUnit.SECONDS))
+ * def.writer.trigger(ProcessingTime.create("10 seconds"))
+ * }}}
+ */
+case class ProcessingTime(intervalMs: Long) extends Trigger {
+ require(intervalMs >= 0, "the interval of trigger should not be
negative")
+}
+
+object ProcessingTime {
+
+ def apply(interval: String): ProcessingTime = {
+ if (StringUtils.isBlank(interval)) {
+ throw new IllegalArgumentException(
+ "interval cannot be null or blank.")
+ }
+ val cal = if (interval.startsWith("interval")) {
--- End diff --
> Is this logic duplicated elsewhere? Should CalendarInterval.fromString
just do this internally?
SQL also uses `CalendarInterval.fromString` to parse the interval and the
syntax requires `INTERVAL value unit`. Hence, I cannot move the logic into
CalendarInterval.fromString
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
