Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11976#discussion_r58272868
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.ProcessingTime
+
+trait TriggerExecutor {
+
+ /**
+ * Execute batches using `batchRunner`. If `batchRunner` runs `false`,
terminate the execution.
+ */
+ def execute(batchRunner: () => Boolean): Unit
+}
+
+/**
+ * A trigger executor that runs a batch every `intervalMs` milliseconds.
+ */
+case class ProcessingTimeExecutor(processingTime: ProcessingTime)
+ extends TriggerExecutor with Logging {
+
+ private val intervalMs = processingTime.intervalMs
+
+ override def execute(batchRunner: () => Boolean): Unit = {
+ while (true) {
+ val batchStartTimeMs = System.currentTimeMillis()
+ if (!batchRunner()) {
+ return
+ }
+ if (intervalMs > 0) {
+ val batchEndTimeMs = System.currentTimeMillis()
+ val batchElapsedTimeMs = batchEndTimeMs - batchStartTimeMs
+ if (batchElapsedTimeMs > intervalMs) {
+ logWarning("Current batch is falling behind. The trigger
interval is " +
+ s"${intervalMs} milliseconds, but spent ${batchElapsedTimeMs}
milliseconds")
+ }
+ waitUntil(nextBatchTime(batchEndTimeMs))
+ }
+ }
+ }
+
+ private def waitUntil(time: Long): Unit = {
+ var now = System.currentTimeMillis()
--- End diff --
I added Clock to ProcessingTimeExecutor and added more tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
