Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12102#discussion_r58289511
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -40,16 +39,38 @@ private[execution] sealed trait HashedRelation {
/**
* Returns matched rows.
*/
- def get(key: InternalRow): Seq[InternalRow]
+ def get(key: InternalRow): Iterator[InternalRow]
/**
* Returns matched rows for a key that has only one column with
LongType.
*/
- def get(key: Long): Seq[InternalRow] = {
+ def get(key: Long): Iterator[InternalRow] = {
throw new UnsupportedOperationException
}
/**
+ * Returns the matched single row.
+ */
+ def getValue(key: InternalRow): InternalRow
+
+ /**
+ * Returns the matched single row with key that have only one column of
LongType.
+ */
+ def getValue(key: Long): InternalRow = {
+ throw new UnsupportedOperationException
+ }
+
+ /**
+ * Returns true iff all the keys are unique.
+ */
+ def allUnique: Boolean
+
+ /**
+ * Returns a read-only copy of this, to be safely used in current thread.
+ */
+ def copy(): HashedRelation
--- End diff --
when i saw this being called, my first guess was that a deep copy was
performed. we should rename it to make it seem lighter weight. maybe
asReadOnlyCopy? similar to the one on ByteBuffer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
