Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12102#discussion_r58289531
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -40,16 +39,38 @@ private[execution] sealed trait HashedRelation {
/**
* Returns matched rows.
*/
- def get(key: InternalRow): Seq[InternalRow]
+ def get(key: InternalRow): Iterator[InternalRow]
--- End diff --
we should make it clear in the documentation what this is supposed to
return when there is no match (null or empty iterator). it actually seems to me
empty iterator is safer?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
