Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58301583
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -453,28 +464,80 @@ class SessionCatalog(
* If a database is specified in `name`, this will return the function
in that database.
* If no database is specified, this will return the function in the
current database.
*/
+ // TODO: have a better name. This method is actually for fetching the
metadata of a function.
def getFunction(name: FunctionIdentifier): CatalogFunction = {
val db = name.database.getOrElse(currentDb)
externalCatalog.getFunction(db, name.funcName)
}
+ /**
+ * Check if a function is already existing.
+ *
+ */
+ def functionExists(name: FunctionIdentifier): Boolean = {
+ if (functionRegistry.functionExists(name.unquotedString)) {
+ // This function exists in the FunctionRegistry.
+ true
+ } else {
+ // Need to check if this function exists in the metastore.
+ try {
+ getFunction(name) != null
+ } catch {
+ case _: NoSuchFunctionException => false
+ case _: AnalysisException => false // HiveExternalCatalog wraps
all exceptions with it.
+ }
+ }
+ }
// ----------------------------------------------------------------
// | Methods that interact with temporary and metastore functions |
// ----------------------------------------------------------------
+
+ /**
+ * Return a temporary function. For testing only.
+ */
+ private[catalog] def getTempFunction(name: String):
Option[FunctionBuilder] = {
+ // TODO: Why do we need this?
--- End diff --
Will delete it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
