Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12117#discussion_r58301786
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -428,53 +432,86 @@ class SessionCatalog(
*/
def dropFunction(name: FunctionIdentifier): Unit = {
val db = name.database.getOrElse(currentDb)
+ val qualified = name.copy(database = Some(db)).unquotedString
+ if (functionRegistry.functionExists(qualified)) {
+ // If we have loaded this function into FunctionRegistry,
+ // also drop it from there.
+ functionRegistry.dropFunction(qualified)
+ }
externalCatalog.dropFunction(db, name.funcName)
}
/**
- * Alter a metastore function whose name that matches the one specified
in `funcDefinition`.
- *
- * If no database is specified in `funcDefinition`, assume the function
is in the
- * current database.
- *
- * Note: If the underlying implementation does not support altering a
certain field,
- * this becomes a no-op.
- */
- def alterFunction(funcDefinition: CatalogFunction): Unit = {
- val db = funcDefinition.identifier.database.getOrElse(currentDb)
- val newFuncDefinition = funcDefinition.copy(
- identifier = FunctionIdentifier(funcDefinition.identifier.funcName,
Some(db)))
- externalCatalog.alterFunction(db, newFuncDefinition)
- }
--- End diff --
Users cannot alter functions (no API exposed). So, I just delete it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
