Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r58320790
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -59,6 +59,8 @@ object DateTimeUtils {
final val toYearZero = to2001 + 7304850
final val TimeZoneGMT = TimeZone.getTimeZone("GMT")
+ lazy val c = Calendar.getInstance(TimeZone.getTimeZone("GMT"))
--- End diff --
Yes if SimpleDateFormat isn't used in multiple threads and you're sure it
can't be, then caching it in the instance is OK.
This however isn't thread-safe. The Calendar would be shared across threads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
