Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12116#discussion_r58492921
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -146,7 +146,9 @@ def get$Name(self):
("weightCol", "weight column name. If this is not set or empty, we
treat " +
"all instance weights as 1.0.", None, "TypeConverters.toString"),
("solver", "the solver algorithm for optimization. If this is not
set or empty, " +
- "default value is 'auto'.", "'auto'", "TypeConverters.toString")]
+ "default value is 'auto'.", "'auto'", "TypeConverters.toString"),
+ ("varianceCol", "column name for the biased sample variance" +
--- End diff --
I think you could merge the description to fit on the first line and do the
linebreak after None - would make it a bit easier to read (but double check
with the pylint script of course)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
