Github user holdenk commented on the pull request:

    https://github.com/apache/spark/pull/12116#issuecomment-205678416
  
    Two minor comments, we could also probably add a simple test to the 
existing decission tree tests in tests.py (nothing too complicated just make 
sure the value is respected - which might be overkill but having a little extra 
test logic makes it easier to catch changes in the Scala API we need to also 
update on the Python side).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to