Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/1076#discussion_r15617668
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -91,6 +91,10 @@ private[spark] class MetricsSystem private (val
instance: String,
sinks.foreach(_.stop)
}
+ def report() {
+ sinks.foreach(_.report)
--- End diff --
Yeah, this is something the Scala developers recommend to differentiate
methods that have no side-effects (e.g. property getters or things like
toString): http://docs.scala-lang.org/style/method-invocation.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
