Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1076#discussion_r15618239
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala 
---
    @@ -91,6 +91,10 @@ private[spark] class MetricsSystem private (val 
instance: String,
         sinks.foreach(_.stop)
       }
     
    +  def report() {
    --- End diff --
    
    Actually one other thing, add `: Unit =` here. The procedure syntax in 
Scala (`def f() { ... }`) is going to be deprecated in terms of always 
specifying a return type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to