Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r59121965
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -283,10 +294,15 @@ class SessionCatalog(
* explicitly specified.
*/
def isTemporaryTable(name: TableIdentifier): Boolean = {
- !name.database.isDefined &&
tempTables.contains(formatTableName(name.table))
+ name.database.isEmpty &&
tempTables.contains(formatTableName(name.table))
}
/**
+ * Return whether View is supported
+ */
+ def isViewSupported: Boolean = false
--- End diff --
OK. I see. We cannot create a view in SQLContext because the parser rule is
in HiveSqlParser, right? So, it is better just remove this method and if a user
calls drop view in SQLContext, because the view is not defined, they can still
see an error message, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]