Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12146#discussion_r59122462
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalogSuite.scala
---
@@ -233,10 +233,10 @@ class SessionCatalogSuite extends SparkFunSuite {
intercept[AnalysisException] {
catalog.dropTable(TableIdentifier("tbl1", Some("unknown_db")),
ignoreIfNotExists = true)
}
- // Table does not exist
- intercept[AnalysisException] {
- catalog.dropTable(TableIdentifier("unknown_table", Some("db2")),
ignoreIfNotExists = false)
- }
+ // If the table does not exist, we do not issue an exception. Instead,
we output an error
+ // message to console when ignoreIfNotExists is set to false. This is
to make it consistent
--- End diff --
Yeah, this is not completely consistent. let me rewrite it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
