Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1680#issuecomment-50711311
This code is fairly complex and I've probably made a mistake somewhere
(registered a bad signal handler, ignored an exception, etc), so I'd greatly
appreciate a thorough review. There might also be an opportunity to fix
[SPARK-1740](https://issues.apache.org/jira/browse/SPARK-1740) in this PR. For
now, this is [WIP]; I'd like to thoroughly comment this code before I commit it.
/cc @davies (who has an outstanding PR, #1643, that modifies this code),
@aarondav (who has contributed bugfixes to this code), and @jey (who
contributed the original `daemon.py`)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
