Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1680#discussion_r15625817
--- Diff: python/pyspark/daemon.py ---
@@ -50,29 +46,16 @@ def compute_real_exit_code(exit_code):
return 1
-def worker(listen_sock):
+def worker(sock):
+ """
+ Called by a worker process after the fork().
+ """
# Redirect stdout to stderr
os.dup2(2, 1)
sys.stdout = sys.stderr # The sys.stdout object is different from
file descriptor 1
- # Manager sends SIGHUP to request termination of workers in the pool
- def handle_sighup(*args):
- assert should_exit()
- signal.signal(SIGHUP, handle_sighup)
-
- # Cleanup zombie children
- def handle_sigchld(*args):
--- End diff --
This file had two different versions of this "cleanup zombie children"
`handle_sigchld` function that are slightly different, so it might be a good
idea to understand whether there's a reason why they differed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
